Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CDN from rawgit to jsDeliver #699

Merged
merged 3 commits into from
May 7, 2019

Conversation

romaninsh
Copy link
Member

Change CDN from rawgit to jsDeliver

Resolves #685

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #699 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #699      +/-   ##
=============================================
+ Coverage      72.55%   72.62%   +0.06%     
  Complexity      1933     1933              
=============================================
  Files            105      105              
  Lines           4559     4559              
=============================================
+ Hits            3308     3311       +3     
+ Misses          1251     1248       -3
Impacted Files Coverage Δ Complexity Δ
src/App.php 72.9% <ø> (ø) 117 <0> (ø) ⬇️
src/TableColumn/Status.php 82.35% <0%> (+8.82%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31c667...8d7ebfa. Read the comment docs.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #699 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #699      +/-   ##
=============================================
+ Coverage      72.55%   72.62%   +0.06%     
  Complexity      1933     1933              
=============================================
  Files            105      105              
  Lines           4559     4559              
=============================================
+ Hits            3308     3311       +3     
+ Misses          1251     1248       -3
Impacted Files Coverage Δ Complexity Δ
src/App.php 72.9% <ø> (ø) 117 <0> (ø) ⬇️
src/TableColumn/Status.php 82.35% <0%> (+8.82%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31c667...23656bb. Read the comment docs.

Copy link
Collaborator

@gowrav-vishwakarma gowrav-vishwakarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well!

@romaninsh
Copy link
Member Author

romaninsh commented May 3, 2019

@gowrav-vishwakarma can you approve then ?

i mean - do you have permissions ?

@gowrav-vishwakarma gowrav-vishwakarma self-requested a review May 4, 2019 18:47
@gowrav-vishwakarma
Copy link
Collaborator

@gowrav-vishwakarma can you approve then ?

i mean - do you have permissions ?

Yes, I can. But once I reviewed with comments, now no option to approve .. looking into it again now

Copy link
Collaborator

@gowrav-vishwakarma gowrav-vishwakarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working Well, (test with approving)

Copy link
Collaborator

@PhilippGrashoff PhilippGrashoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any link to rawgit in docs anymore.
All works fine.

@DarkSide666 DarkSide666 merged commit 2c0b756 into develop May 7, 2019
@DarkSide666 DarkSide666 deleted the migrate-from-rawgit-to-jsdeliver branch May 7, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RawGit is shutting down. The latest example defaults to RawGit shared resources.
4 participants