-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CDN from rawgit to jsDeliver #699
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #699 +/- ##
=============================================
+ Coverage 72.55% 72.62% +0.06%
Complexity 1933 1933
=============================================
Files 105 105
Lines 4559 4559
=============================================
+ Hits 3308 3311 +3
+ Misses 1251 1248 -3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #699 +/- ##
=============================================
+ Coverage 72.55% 72.62% +0.06%
Complexity 1933 1933
=============================================
Files 105 105
Lines 4559 4559
=============================================
+ Hits 3308 3311 +3
+ Misses 1251 1248 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well!
@gowrav-vishwakarma can you approve then ? i mean - do you have permissions ? |
Yes, I can. But once I reviewed with comments, now no option to approve .. looking into it again now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working Well, (test with approving)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any link to rawgit in docs anymore.
All works fine.
Change CDN from rawgit to jsDeliver
Resolves #685