features/MultiLine Form Field

[ibelar]

MultiLine field

New form input in order to allow add/edit multiple record within a form.

Usage

$f = $app->add('Form');
$f->setModel($invoice, false);

$sub_layout = $f->layout->addSubLayout('Generic');
$sub_layout->setModel($invoice, ['name', 'client_id', 'address']);

$sub_layout = $f->layout->addSubLayout('Generic');

//Add multi line input to the layout.
$ml = $sub_layout->addField('ml', ['MultiLine']);
$ml->setModel($invoice, ['item','cat','qty','price', 'sub', 'tx', 'grd'], 'Items', 'invoice_id');

// add onchange handler and update grand total.
$ml->onChange(function($rows) use ($f) {
    $total = 0;
    foreach ($rows as $row => $cols) {
        foreach ($cols as $col) {
            $fieldName = key($col);
            if ($fieldName === 'grd') {
                $total = $total + substr($col[$fieldName], 4);
            }
        }
    }
 return $f->js(true, null, 'input[name="g_total"]')->val(number_format($total, 2));

}, ['qty', 'price']);

Demo file

multiline.php

Feature

• Adding row will use Model/Field default value if set.
• Multiple row deletion;
• Calculate Expression or Callback value from Field definition;
• onChange callback for entire row record or on specify field.
• Validate according to Field definition in model.
• Validation is apply on every row when form is saved.

[codecov]

Codecov Report

Merging #700 into develop will decrease coverage by 29.21%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             develop     #700       +/-   ##
==============================================
- Coverage      72.55%   43.34%   -29.22%     
- Complexity      1933     2047      +114     
==============================================
  Files            105      106        +1     
  Lines           4559     4960      +401     
==============================================
- Hits            3308     2150     -1158     
- Misses          1251     2810     +1559

Impacted Files	Coverage Δ	Complexity Δ
src/FormField/MultiLine.php	0% <0%> (ø)	110 <110> (?)
src/AccordionSection.php	0% <0%> (-100%)	3% <0%> (ø)
src/HelloWorld.php	0% <0%> (-100%)	1% <0%> (ø)
src/Layout/Centered.php	0% <0%> (-100%)	1% <0%> (ø)
src/FormField/Radio.php	0% <0%> (-100%)	16% <0%> (ø)
src/FormField/Money.php	0% <0%> (-100%)	6% <0%> (ø)
src/Columns.php	0% <0%> (-100%)	10% <0%> (ø)
src/TableColumn/Password.php	0% <0%> (-100%)	1% <0%> (ø)
src/FormLayout/Section/Generic.php	0% <0%> (-100%)	1% <0%> (ø)
src/FormField/TextArea.php	0% <0%> (-100%)	5% <0%> (ø)
... and 72 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31c667...1622264. Read the comment docs.

[codecov]

Codecov Report

Merging #700 into develop will decrease coverage by 3.73%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #700      +/-   ##
=============================================
- Coverage      72.55%   68.82%   -3.74%     
- Complexity      1933     2043     +110     
=============================================
  Files            105      106       +1     
  Lines           4559     4811     +252     
=============================================
+ Hits            3308     3311       +3     
- Misses          1251     1500     +249

Impacted Files	Coverage Δ	Complexity Δ
src/FormField/MultiLine.php	0% <0%> (ø)	110 <110> (?)
src/TableColumn/Status.php	82.35% <0%> (+8.82%)	12% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31c667...bb4266e. Read the comment docs.

[romaninsh]

I'd like $rows to be a model linked with array persistence. Also - user should be able to change that with effect on the UI.

@ibelar are you sending ALL the rows back to the frontend or just changed ones ?

EDIT: let's leave that for the future.

[romaninsh]

very valuable. I do want to change many things, but that can be done at a later time.

[romaninsh]

we should only catch and display validation errors (they have a dedicated class).

[ibelar]

Was not sure how to check for post load validation error. Thought that typecastLoadField was supposed to do so. Let me know how this should work and I can change it.

[romaninsh]

could this be using callback's trigger value?

[ibelar]

The callback url is render only once for the component but the same callback url is used for two different action.

[romaninsh]

ok, FOR NOW, but would have to refactor.

[romaninsh]

rather should rely on Model's callbacks.. OK for now. Or rather Persistence should do this.

[romaninsh]

can't merge, CI fails.

[ibelar]

@romaninsh - ci should passed now. Rename onChange method to onLineChange...

[romaninsh]

Thanks!