-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/Alert user when leaving page with un submit form. #705
Conversation
does this also apply on regular as well as multi-line form? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@ibelar this breaks test-scripts.. .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaks selenium...
Codecov Report
@@ Coverage Diff @@
## develop #705 +/- ##
==============================================
- Coverage 68.75% 43.28% -25.47%
- Complexity 2046 2051 +5
==============================================
Files 106 106
Lines 4813 4969 +156
==============================================
- Hits 3309 2151 -1158
- Misses 1504 2818 +1314
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #705 +/- ##
============================================
+ Coverage 68.75% 68.85% +0.1%
- Complexity 2046 2047 +1
============================================
Files 106 106
Lines 4813 4819 +6
============================================
+ Hits 3309 3318 +9
+ Misses 1504 1501 -3
Continue to review full report at Codecov.
|
@romaninsh - I added change to fix test. Yes, may be used on all form. Form using Calendar field might not detect changed on these field. |
Alert user when leaving page with un submit form data.