Allow easy routing implementation #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you extend App class and want to use routing in place of direct call to files, you have to complete override the method url of App, to change only 2 occurence of ".php", even if the first occurence at line 542 is only for completeness, the other one on line 587 must be changed to avoid reparsing the result of a parent::url(args) if you plan to only partially override that is nonsense. i put the variable protected because is something that never change and must work in extended class.
Add comments
Codecov Report
@@ Coverage Diff @@
## develop #706 +/- ##
==========================================
Coverage 68.85% 68.85%
Complexity 2047 2047
==========================================
Files 106 106
Lines 4819 4819
==========================================
Hits 3318 3318
Misses 1501 1501
Continue to review full report at Codecov.
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you extend App class and want to use routing in place of direct call to files, you have to complete override the method url of App, to change only 2 occurence of ".php", even if the first occurence at line 542 is only for completeness, the other one on line 587 must be changed to avoid reparsing the result of a parent::url(args) if you plan to only partially override that is nonsense.
i put the variable protected because is something that never change and must work in extended class.