Add TableColumn Caption definition in model #708
Conversation
In Model we can define the default caption for the field, usually in Table we use abbreviation or acronim of that long caption, to centralize TableColumn the definition of the ui rappresentation of the field in all table.
Codecov Report
@@ Coverage Diff @@
## develop #708 +/- ##
=============================================
- Coverage 68.84% 68.72% -0.13%
- Complexity 2049 2055 +6
=============================================
Files 106 106
Lines 4825 4837 +12
=============================================
+ Hits 3322 3324 +2
- Misses 1503 1513 +10
Continue to review full report at Codecov.
|
|
Please check my proposal. |
|
Hi guys, what's the status of this? |
|
it works and has passed all test, i already said that i can't see the proposal made by @romaninsh |
|
This looks good, but would like to see @romaninsh proposal. |
|
@romaninsh we couldn't find your proposal on this thread or Gitter. Can you post it? Thanks! |
src/TableColumn/Generic.php
Outdated
| // if $this->caption is empty, header caption will be overriden by linked field definition | ||
| if (empty($this->caption)) { | ||
| $caption = $f->getCaption(); | ||
| } |
There was a problem hiding this comment.
what if it's not empty? $caption will be undefined?
There was a problem hiding this comment.
$caption = empty($this->caption) ? $f->getCaption : $this->caption;
|
sorry, forgetting to submit the comments 😆 . |
In Model we can define the default caption for the field, usually in Table we use abbreviation or acronim of that long caption, to centralize TableColumn the definition of the ui rappresentation of the field in all table.