Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #719 and #720 #721

Merged
merged 5 commits into from
May 27, 2019
Merged

Fix #719 and #720 #721

merged 5 commits into from
May 27, 2019

Conversation

DarkSide666
Copy link
Member

Fix #719 and #720

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #721 into develop will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #721      +/-   ##
=============================================
- Coverage      68.76%   68.71%   -0.06%     
- Complexity      2052     2054       +2     
=============================================
  Files            106      106              
  Lines           4831     4836       +5     
=============================================
+ Hits            3322     3323       +1     
- Misses          1509     1513       +4
Impacted Files Coverage Δ Complexity Δ
src/Grid.php 73.41% <25%> (-1.26%) 64 <0> (+2)
src/CRUD.php 47.36% <75%> (-0.64%) 54 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f885afc...1a8c0a6. Read the comment docs.

Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@romaninsh
Copy link
Member

PHP Notice: Use of undefined constant menu - assumed 'menu' in /home/travis/build/atk4/ui/src/CRUD.php on line 136

@DarkSide666 DarkSide666 merged commit b4b0aa8 into develop May 27, 2019
@DarkSide666 DarkSide666 deleted the feature/fix-720 branch May 27, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in custom CRUD->itemCreate support
3 participants