Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/File upload - jsModal Css #722

Merged
merged 2 commits into from
May 27, 2019
Merged

fix/File upload - jsModal Css #722

merged 2 commits into from
May 27, 2019

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented May 24, 2019

fix #717

Other Fix:

  • Babel configuration.
    • fix core.js warning during build.
  • file-upload.plugin
    • remove support for opening file dialog when input get focus. Because File dialog
      will blur and re focus input field again. This was causing file dialog to open
      multiple times. Now only open when input or button is clicked.

Enhancement

  • create-modal.plugin
    Now allow to pass css class name to create modal.
    Useful when need to create modal with full width for example.
$btn = $app->add(['Button', 'Add']);
$btn->on('click', (new jsModal('Add new', $vp))->setOption('modalCss', 'fullscreen'));

@ibelar
fix/File upload - jsModal Css
33c9ab5 
- Babel configuration.
    - fix core.js warning during build.
- create-modal.pluing
    - fix: now allow to pass css class name to create modal.
    Useful when need to create modal with full width for example.
- file-upload.plugin
    - remove support for opening file dialog when input get focus. Because File dialog
    will remove blur and focus input field again, this was causing the file dialog to open
    multiple time. Now only open when input or button is clicked.
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #722 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #722   +/-   ##
==========================================
  Coverage      68.76%   68.76%           
  Complexity      2052     2052           
==========================================
  Files            106      106           
  Lines           4831     4831           
==========================================
  Hits            3322     3322           
  Misses          1509     1509
Impacted Files Coverage Δ Complexity Δ
src/FormField/Upload.php 60% <ø> (ø) 35 <0> (ø) ⬇️
src/jsModal.php 62.5% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f885afc...33c9ab5. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #722 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #722   +/-   ##
==========================================
  Coverage      68.76%   68.76%           
  Complexity      2052     2052           
==========================================
  Files            106      106           
  Lines           4831     4831           
==========================================
  Hits            3322     3322           
  Misses          1509     1509
Impacted Files Coverage Δ Complexity Δ
src/FormField/Upload.php 60% <ø> (ø) 35 <0> (ø) ⬇️
src/jsModal.php 62.5% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f885afc...33c9ab5. Read the comment docs.

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #722 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #722   +/-   ##
==========================================
  Coverage      68.76%   68.76%           
  Complexity      2052     2052           
==========================================
  Files            106      106           
  Lines           4831     4831           
==========================================
  Hits            3322     3322           
  Misses          1509     1509
Impacted Files Coverage Δ Complexity Δ
src/FormField/Upload.php 60% <ø> (ø) 35 <0> (ø) ⬇️
src/jsModal.php 62.5% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f885afc...33c9ab5. Read the comment docs.

@codecov
Copy link

codecov bot commented May 24, 2019 •
edited
Loading

Codecov Report

Merging #722 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #722   +/-   ##
==========================================
  Coverage      68.76%   68.76%           
  Complexity      2052     2052           
==========================================
  Files            106      106           
  Lines           4831     4831           
==========================================
  Hits            3322     3322           
  Misses          1509     1509
Impacted Files Coverage Δ Complexity Δ
src/FormField/Upload.php 60% <ø> (ø) 35 <0> (ø) ⬇️
src/jsModal.php 62.5% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f885afc...76c7f6a. Read the comment docs.

@PhilippGrashoff
Copy link
Collaborator

Thumbs up for the modal enhancement, very nice feature

@DarkSide666 DarkSide666 self-requested a review May 27, 2019 16:26
DarkSide666
DarkSide666 approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, thanks!

@DarkSide666 DarkSide666 merged commit ead515c into develop May 27, 2019
@DarkSide666 DarkSide666 deleted the fix/jspackage-misc branch May 27, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload field dialog opens multiple times
3 participants
@ibelar @PhilippGrashoff @DarkSide666