Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative status #738

Merged
merged 2 commits into from
Jun 12, 2019
Merged

fix negative status #738

merged 2 commits into from
Jun 12, 2019

Conversation

DarkSide666
Copy link
Member

Fix table column decorator in case of negative status

@romaninsh romaninsh force-pushed the feature/fix-status-negative branch from 6981949 to c59084a Compare June 12, 2019 22:19
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased and re-pushed the branch.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #738 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #738   +/-   ##
==========================================
  Coverage      66.05%   66.05%           
  Complexity      2223     2223           
==========================================
  Files            118      118           
  Lines           5235     5235           
==========================================
  Hits            3458     3458           
  Misses          1777     1777
Impacted Files Coverage Δ Complexity Δ
src/Table.php 86.34% <ø> (ø) 112 <0> (ø) ⬇️
src/Header.php 100% <100%> (ø) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6565b7c...c59084a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #738 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #738   +/-   ##
==========================================
  Coverage      66.05%   66.05%           
  Complexity      2223     2223           
==========================================
  Files            118      118           
  Lines           5235     5235           
==========================================
  Hits            3458     3458           
  Misses          1777     1777
Impacted Files Coverage Δ Complexity Δ
src/Table.php 86.34% <ø> (ø) 112 <0> (ø) ⬇️
src/Header.php 100% <100%> (ø) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6565b7c...c59084a. Read the comment docs.

@romaninsh romaninsh merged commit 3032d32 into develop Jun 12, 2019
@romaninsh romaninsh deleted the feature/fix-status-negative branch June 12, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants