Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature2/card #742

Merged
merged 18 commits into from
Jun 12, 2019
Merged

Feature2/card #742

merged 18 commits into from
Jun 12, 2019

Conversation

romaninsh
Copy link
Member

@romaninsh romaninsh commented Jun 12, 2019

REMERGE of #735

New View Class as per Fomantic Ui Card View

Usage:

$card_h = $app->add('CardHolder');
$card_h->addContent(new \atk4\ui\Header(['Project Info']));
$stats = (new Stat($db))->tryLoadAny();

$card_h->setModel($stats, ['project_name', 'project_code', 'client_name']);

$card_h->addButton(new \atk4\ui\Button(['Email Client']));

see demos/cardholder for more options

Screen Shot 2019-06-05 at 7 55 16 PM

@romaninsh romaninsh requested a review from ibelar June 12, 2019 21:51
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #742 into develop2 will decrease coverage by 1.09%.
The diff coverage is 6.59%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop2     #742     +/-   ##
=============================================
- Coverage       67.48%   66.38%   -1.1%     
- Complexity       2092     2129     +37     
=============================================
  Files             109      110      +1     
  Lines            4921     5007     +86     
=============================================
+ Hits             3321     3324      +3     
- Misses           1600     1683     +83
Impacted Files Coverage Δ Complexity Δ
src/FormField/CheckBox.php 92.59% <ø> (ø) 12 <0> (ø) ⬇️
src/App.php 72.22% <0%> (-0.58%) 117 <0> (ø)
src/FormField/MultiLine.php 0% <0%> (ø) 111 <0> (+1) ⬆️
src/CardHolder.php 0% <0%> (ø) 35 <35> (?)
src/Card.php 95.45% <100%> (ø) 11 <0> (+1) ⬆️
src/View.php 82.89% <100%> (ø) 147 <0> (ø) ⬇️
src/Component/ItemSearch.php 96.77% <100%> (+0.34%) 11 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0657041...818fc93. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #742 into develop2 will decrease coverage by 1.09%.
The diff coverage is 6.59%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop2     #742     +/-   ##
=============================================
- Coverage       67.48%   66.38%   -1.1%     
- Complexity       2092     2129     +37     
=============================================
  Files             109      110      +1     
  Lines            4921     5007     +86     
=============================================
+ Hits             3321     3324      +3     
- Misses           1600     1683     +83
Impacted Files Coverage Δ Complexity Δ
src/FormField/CheckBox.php 92.59% <ø> (ø) 12 <0> (ø) ⬇️
src/App.php 72.22% <0%> (-0.58%) 117 <0> (ø)
src/FormField/MultiLine.php 0% <0%> (ø) 111 <0> (+1) ⬆️
src/CardHolder.php 0% <0%> (ø) 35 <35> (?)
src/Card.php 95.45% <100%> (ø) 11 <0> (+1) ⬆️
src/View.php 82.89% <100%> (ø) 147 <0> (ø) ⬇️
src/Component/ItemSearch.php 96.77% <100%> (+0.34%) 11 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0657041...818fc93. Read the comment docs.

@romaninsh romaninsh merged commit 84d05b4 into develop2 Jun 12, 2019
@mvorisek mvorisek deleted the feature2/card branch May 11, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants