Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature2/cardholder #744

Merged
merged 14 commits into from
Jun 12, 2019
Merged

Feature2/cardholder #744

merged 14 commits into from
Jun 12, 2019

Conversation

romaninsh
Copy link
Member

REMERGE of #735

Bugfixes to Cardholder implementation (as per feedback from @romaninsh )

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #744 into develop2 will decrease coverage by 0.21%.
The diff coverage is 61.65%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop2     #744      +/-   ##
==============================================
- Coverage       66.38%   66.17%   -0.22%     
- Complexity       2129     2231     +102     
==============================================
  Files             110      118       +8     
  Lines            5007     5259     +252     
==============================================
+ Hits             3324     3480     +156     
- Misses           1683     1779      +96
Impacted Files Coverage Δ Complexity Δ
src/ActionExecutor/Event.php 0% <0%> (ø) 14 <14> (?)
src/CardDeck.php 100% <100%> (ø) 3 <3> (?)
src/Card.php 62.61% <62.26%> (-32.84%) 51 <51> (+40)
src/CardSection.php 89.28% <89.28%> (ø) 12 <12> (?)
src/CardTable.php 90.9% <90.9%> (ø) 11 <11> (?)
src/TableColumn/Status.php 76.47% <0%> (-5.89%) 12% <0%> (ø)
src/TableColumn/Labels.php 0% <0%> (ø) 3% <0%> (?)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d05b4...af2fdd1. Read the comment docs.

@romaninsh romaninsh merged commit 6565b7c into develop2 Jun 12, 2019
@mvorisek mvorisek deleted the feature2/Cardholder branch May 11, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants