Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/Add section with no model #745

Merged
merged 1 commit into from
Jun 13, 2019
Merged

fix/Add section with no model #745

merged 1 commit into from
Jun 13, 2019

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Jun 13, 2019

Setting model is not need when adding a section with just a title only.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #745 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #745      +/-   ##
=============================================
+ Coverage      66.03%   66.05%   +0.01%     
  Complexity      2223     2223              
=============================================
  Files            118      118              
  Lines           5235     5235              
=============================================
+ Hits            3457     3458       +1     
+ Misses          1778     1777       -1
Impacted Files Coverage Δ Complexity Δ
src/Card.php 62.61% <100%> (ø) 51 <0> (ø) ⬇️
src/TableColumn/Status.php 82.35% <0%> (+2.94%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce15ab...f175722. Read the comment docs.

@romaninsh romaninsh merged commit 2635175 into develop Jun 13, 2019
@romaninsh romaninsh deleted the fix/card-section branch June 13, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants