Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/ js Executor for Action #751

Merged
merged 3 commits into from
Jun 21, 2019
Merged

feature/ js Executor for Action #751

merged 3 commits into from
Jun 21, 2019

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Jun 19, 2019

This replace ActionExecutor\Event

Screen Shot 2019-06-19 at 7 41 27 PM

Usage

$btn = $app->add(['Button', 'Click for action']);
$btn->on('click', new jsEvent($btn, $action));

Demo

jsactions.php

ibelar and others added 2 commits June 19, 2019 19:42
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #751 into develop will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #751      +/-   ##
=============================================
- Coverage      66.05%   65.97%   -0.08%     
- Complexity      2223     2225       +2     
=============================================
  Files            118      118              
  Lines           5235     5241       +6     
=============================================
  Hits            3458     3458              
- Misses          1777     1783       +6
Impacted Files Coverage Δ Complexity Δ
src/Card.php 60.9% <0%> (-1.71%) 53 <4> (+2)
src/ActionExecutor/jsEvent.php 0% <0%> (ø) 14 <14> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2635175...1245836. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #751 into develop will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #751      +/-   ##
=============================================
- Coverage      66.05%   65.97%   -0.08%     
- Complexity      2223     2225       +2     
=============================================
  Files            118      118              
  Lines           5235     5241       +6     
=============================================
  Hits            3458     3458              
- Misses          1777     1783       +6
Impacted Files Coverage Δ Complexity Δ
src/Card.php 60.9% <0%> (-1.71%) 53 <4> (+2)
src/ActionExecutor/jsEvent.php 0% <0%> (ø) 14 <14> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2635175...15c699b. Read the comment docs.

Add callback to context instead of app
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romaninsh romaninsh merged commit 8decc38 into develop Jun 21, 2019
@romaninsh romaninsh deleted the feature/js-executor branch June 21, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants