Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix #755" #761

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Conversation

romaninsh
Copy link
Member

Reverts #756

@romaninsh romaninsh merged commit 5a70b40 into develop Jul 1, 2019
@DarkSide666
Copy link
Member

did this really helped to fix issue ??

@acicovic
Copy link
Collaborator

acicovic commented Jul 1, 2019

@DarkSide666 yes, this solved it for me (and apparently for @romaninsh as well) but this is really strange.

@acicovic
Copy link
Collaborator

acicovic commented Jul 1, 2019

I see that the whole commit has been reverted. In my tests, changing only textarea.php was enough to fix the issue. But I have no idea.

@romaninsh
Copy link
Member Author

@acicovic @DarkSide666 please prepare a fixed PR & test.

@romaninsh romaninsh deleted the revert-756-feature/fix-empty-field-value branch July 1, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants