Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using afterSuccess and apiConfig in View and Grid (jsReload) #769

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Conversation

pkly
Copy link
Contributor

@pkly pkly commented Jul 5, 2019

Quality of life change really, allows for skipping using jsReload all together (meaning also less imports in non-atk code) when dealing with View-based objects, as you can do everything you can with a jsReload now by proxy.

Previously (in js-callbacks):

$obj = $app->add(['View']);

return [
    new jsReload($obj, [], new jsExpression('something.here();'));
];

Now:

$obj = $app->add(['View']);

return [
   $obj->jsReload([], new jsExpression('something.here();'));
];

@pkly pkly changed the title Add support for using afterSuccess and apiConfig in View and Grid Add support for using afterSuccess and apiConfig in View and Grid (jsReload) Jul 5, 2019
@romaninsh romaninsh requested a review from ibelar July 8, 2019 12:16
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks harmless!

@romaninsh romaninsh merged commit acb176f into atk4:develop Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants