Gowrav vishwakarma ui editable bug

[romaninsh]

Implementation of New test case for ui=>editable test (by @gowrav-vishwakarma )

$this->addField('no_persist_but_show_in_ui',['never_persist'=>true,'ui'=>['editable'=>true]]);
// this should not be readonly in ui
..

closes #698

[codecov]

Codecov Report

Merging #782 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #782      +/-   ##
=============================================
+ Coverage      71.24%   71.28%   +0.03%     
  Complexity      2244     2244              
=============================================
  Files            119      119              
  Lines           5325     5325              
=============================================
+ Hits            3794     3796       +2     
+ Misses          1531     1529       -2

Impacted Files	Coverage Δ	Complexity Δ
src/FormLayout/_Abstract.php	77.27% <0%> (+3.03%)	31% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc25357...4620704. Read the comment docs.

[codecov]

Codecov Report

Merging #782 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #782      +/-   ##
=============================================
+ Coverage      71.24%   71.28%   +0.03%     
  Complexity      2244     2244              
=============================================
  Files            119      119              
  Lines           5325     5325              
=============================================
+ Hits            3794     3796       +2     
+ Misses          1531     1529       -2

Impacted Files	Coverage Δ	Complexity Δ
src/FormLayout/_Abstract.php	77.27% <0%> (+3.03%)	31% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc25357...4620704. Read the comment docs.

[acicovic]

@gowrav-vishwakarma Can you review this PR so we can close both the issue and the PR if it's good?

Thanks!

[gowrav-vishwakarma]

Sure, I'll update code tomorrow and check it again.

…

On Wed, Jul 31, 2019, 8:24 PM Alex Cicovic ***@***.***> wrote: @gowrav-vishwakarma <https://github.com/gowrav-vishwakarma> Can you review this PR so we can close both the issue and the PR if it's good? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#782?email_source=notifications&email_token=AAHWCUYNU3LZFCR7KNGQ55TQCGRRBA5CNFSM4IGCYWWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3HQSMA#issuecomment-516884784>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHWCU6GRLREA2XJII7IHGDQCGRRBANCNFSM4IGCYWWA> .

[gowrav-vishwakarma]

This works well now !!!

[romaninsh]

hehe finally!!