Feature/fix textarea

[DarkSide666]

Related: #755, #760, #781

Needs testing and try to reproduce HTML markup bug we faced before. I couldn't find how to reproduce that.

Tests are in /demos/form.php

[PhilippGrashoff]

Looks way cleaner than code before!

[romaninsh]

Use this test template and add unit tests:

#776

But yes - looks cleaner!

[edit: linked to incorrect file, it's FormTest.php]

[romaninsh]

nevermind i'll add test..

[romaninsh]

@DarkSide666 - here is a test for dropdown value with key '0' which currently is considered invalid incorrect selection.

[romaninsh]

@DarkSide666 i have added a test-suite, but it still not working with 'values'=>['0'=>'Female'] , so

not fixing #781

[acicovic]

Unfortunately the HTML markup bug (#760) reoccurs for me with this code. @romaninsh is everything OK on your side?

[romaninsh]

@acicovic - i haven't tested against the project actually, have been a bit busy. @DarkSide666 can you see if saasty admin works OK (it uses mastercrud heavily)

[codecov]

Codecov Report

Merging #783 into develop will increase coverage by 0.11%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             develop    #783      +/-   ##
============================================
+ Coverage      71.18%   71.3%   +0.11%     
+ Complexity      2246    2242       -4     
============================================
  Files            119     119              
  Lines           5328    5325       -3     
============================================
+ Hits            3793    3797       +4     
+ Misses          1535    1528       -7

Impacted Files	Coverage Δ	Complexity Δ
src/Form.php	78.08% <ø> (+2.05%)	68 <0> (ø)	⬇️
src/FormField/TextArea.php	100% <100%> (ø)	3 <0> (-2)	⬇️
src/FormField/DropDown.php	90.12% <100%> (+2.02%)	39 <0> (-2)	⬇️
src/TableColumn/Status.php	82.85% <0%> (+5.71%)	12% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed93f2...322f797. Read the comment docs.

[codecov]

Codecov Report

Merging #783 into develop will increase coverage by 0.09%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             develop     #783      +/-   ##
=============================================
+ Coverage      71.17%   71.26%   +0.09%     
+ Complexity      2246     2242       -4     
=============================================
  Files            119      119              
  Lines           5328     5325       -3     
=============================================
+ Hits            3792     3795       +3     
+ Misses          1536     1530       -6

Impacted Files	Coverage Δ	Complexity Δ
src/Form.php	78.08% <ø> (+2.05%)	68 <0> (ø)	⬇️
src/FormField/TextArea.php	100% <100%> (ø)	3 <0> (-2)	⬇️
src/FormField/DropDown.php	90.12% <100%> (+2.02%)	39 <0> (-2)	⬇️
src/TableColumn/Status.php	82.85% <0%> (+2.85%)	12% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac79ff6...e322a88. Read the comment docs.

[acicovic]

For me this resolves #755 and #760. Doesn't fix #781 but this is not related to textarea per se, so I propose to merge this and we can tackle #781 afterwards.

[DarkSide666]

fix #755
fix #760