Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify setStyle method #788

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Simplify setStyle method #788

merged 1 commit into from
Jul 31, 2019

Conversation

DarkSide666
Copy link
Member

@DarkSide666 DarkSide666 commented Jul 29, 2019

It just simplifies this method.

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #788 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #788      +/-   ##
=============================================
+ Coverage      71.18%   71.23%   +0.04%     
  Complexity      2246     2246              
=============================================
  Files            119      119              
  Lines           5328     5326       -2     
=============================================
+ Hits            3793     3794       +1     
+ Misses          1535     1532       -3
Impacted Files Coverage Δ Complexity Δ
src/View.php 85.5% <100%> (-0.09%) 142 <5> (ø)
src/Console.php 81.5% <0%> (+0.68%) 62% <0%> (ø) ⬇️
src/TableColumn/Status.php 82.85% <0%> (+5.71%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed93f2...7246287. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@abbadon1334 abbadon1334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkSide666 DarkSide666 merged commit 645d895 into develop Jul 31, 2019
@DarkSide666 DarkSide666 deleted the feature/set-add-style branch July 31, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants