Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/CaughException Layout #800

Merged
merged 1 commit into from
Sep 19, 2019
Merged

fix/CaughException Layout #800

merged 1 commit into from
Sep 19, 2019

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Sep 18, 2019

Need to send proper class identifier when App is extended and initLayout is override like below. Otherwise, layout class is not found and exception is never shown.

    public function initLayout($seed, $options = [])
    {
        $ret = parent::initLayout($this->factory($seed, null, '\saasty\frontend\Layout'));
        // code here
        return $ret;
    }

With current implementation, it will try to create layout using 'sassy\frontend\Layout\Centered' which does not exist. This fix make sure we are passing the right class name to initLayout.

- When children App is created
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #800 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #800   +/-   ##
==========================================
  Coverage      76.49%   76.49%           
  Complexity      2252     2252           
==========================================
  Files            119      119           
  Lines           5340     5340           
==========================================
  Hits            4085     4085           
  Misses          1255     1255
Impacted Files Coverage Δ Complexity Δ
src/App.php 82.81% <100%> (ø) 131 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73bc229...7f6678b. Read the comment docs.

@DarkSide666 DarkSide666 self-requested a review September 19, 2019 17:18
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yum

@romaninsh romaninsh merged commit 4f21a42 into develop Sep 19, 2019
@romaninsh romaninsh deleted the fix/caugthException-layout branch September 19, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants