Fix #805

[karakal]

#Fix of Error in addFilterColumn (see ticket #805 ).

[codecov]

Codecov Report

Merging #806 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #806      +/-   ##
=============================================
+ Coverage      76.23%   76.28%   +0.04%     
- Complexity      2291     2293       +2     
=============================================
  Files            119      119              
  Lines           5404     5414      +10     
=============================================
+ Hits            4120     4130      +10     
  Misses          1284     1284

Impacted Files	Coverage Δ	Complexity Δ
src/FormField/Input.php	100% <0%> (ø)	32% <0%> (+2%)	⬆️
src/FormField/DropDown.php	92.68% <0%> (+0.09%)	39% <0%> (ø)	⬇️
src/FormField/Lookup.php	76.5% <0%> (+0.12%)	56% <0%> (ø)	⬇️
src/FormField/AutoComplete.php	66.31% <0%> (+0.35%)	33% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae88ae...5d61d81. Read the comment docs.

[abbadon1334]

@acicovic di you test it? i don't, but the issue is clear
LGTM ( i remove the extra line to pass the tests )
@karakal thanks!

[acicovic]

@abbadon1334 that was my thought also, but after testing I see that it doesn't behave exactly like TypeString as the column expands at maximum width. So the exception is indeed fixed but there should be an additional fix to make it work like string. I suspect the factoryType() function within FilterModel\Generic. Will take a look at it if I have time. @karakal if you have the time to spot and fix this, go ahead.

[acicovic]

OK, so this is by design. ATK assigns an atk-cell-expanded class in TableColumn\Text.php. This is what makes it look different, and for a text field this is logical. So merging this.