Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclickable Autocomplete/Lookup fields #808

Merged
merged 4 commits into from
Oct 6, 2019
Merged

Fix unclickable Autocomplete/Lookup fields #808

merged 4 commits into from
Oct 6, 2019

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented Oct 2, 2019

In Autocomplete and Lookup controls, a large area of the control is unclickable, showing a hand cursor. This makes those controls effectively unusable.

image

The issue is reproducible in the current demo (for example https://ui.agiletoolkit.org/demos/autocomplete.php - hovering over Country1/2/3 towards the right will produce the hand cursor and unclickable control).

This PR fixes the issue for both controls.

@acicovic acicovic requested a review from ibelar October 2, 2019 19:43
Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch! But please update both .pug file accordingly.

@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

Merging #808 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #808   +/-   ##
==========================================
  Coverage      76.28%   76.28%           
  Complexity      2294     2294           
==========================================
  Files            119      119           
  Lines           5414     5414           
==========================================
  Hits            4130     4130           
  Misses          1284     1284

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781243e...c53d24c. Read the comment docs.

@acicovic
Copy link
Collaborator Author

acicovic commented Oct 6, 2019

@ibelar updated pug files.

@ibelar ibelar self-requested a review October 6, 2019 18:59
Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ibelar ibelar merged commit 20a8581 into atk4:develop Oct 6, 2019
@acicovic acicovic deleted the feature/fix-autocomplete-lookup-click branch October 7, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants