Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/TreeItemSelector Form Field #812

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Oct 7, 2019

Implementation of TreeItemSelector Input Field

  • Will display a list of items in a hierarchical (tree) like structure and collects id's select by user.
  • Work in multiple selection mode (allowMultiple = true) or single selection mode.

Screen Shot 2019-10-07 at 11 54 48 AM

Basic Usage

See './demos/tree-item-selector.php' for more detail on how to setup and use this input field.

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #812 into develop will increase coverage by <.01%.
The diff coverage is 67.64%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #812      +/-   ##
=============================================
+ Coverage      76.29%   76.29%   +<.01%     
- Complexity      2294     2307      +13     
=============================================
  Files            119      120       +1     
  Lines           5417     5451      +34     
=============================================
+ Hits            4133     4159      +26     
- Misses          1284     1292       +8
Impacted Files Coverage Δ Complexity Δ
src/FormField/TreeItemSelector.php 67.64% <67.64%> (ø) 13 <13> (?)
src/Persistence/UI.php 62.96% <0%> (+3.7%) 43% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c81a7...7385895. Read the comment docs.

@romaninsh
Copy link
Member

@ibelar conflicts...

@ibelar
Copy link
Contributor Author

ibelar commented Oct 8, 2019

@ibelar conflicts...

@romans - Resolve

@romaninsh romaninsh merged commit 92a4405 into develop Oct 29, 2019
@romaninsh romaninsh deleted the feature/tree-item-selector branch October 29, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants