Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Escape key clear Grid Search #815

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Make Escape key clear Grid Search #815

merged 1 commit into from
Oct 8, 2019

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented Oct 7, 2019 •
edited
Loading

Implements #711

  • Pressing Escape on Grid QuickSearch clears its text.
  • Pressing Escape when the text is empty bubbles up the event.

Note: to be able to use this, you will need the compiled JS file, or when a new ATK UI release will be made.

@acicovic acicovic requested a review from ibelar October 7, 2019 20:37
@acicovic acicovic mentioned this pull request Oct 7, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 7, 2019 •
edited
Loading

Codecov Report

Merging #815 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #815   +/-   ##
==========================================
  Coverage      76.28%   76.28%           
  Complexity      2294     2294           
==========================================
  Files            119      119           
  Lines           5414     5414           
==========================================
  Hits            4130     4130           
  Misses          1284     1284

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a8581...748783f. Read the comment docs.

romaninsh
romaninsh approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and simple, thanks!

@romaninsh romaninsh merged commit d876ab4 into atk4:develop Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaninsh romaninsh romaninsh approved these changes

@ibelar ibelar Awaiting requested review from ibelar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acicovic @romaninsh