Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/MultiLine Improvement #816

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Oct 7, 2019

  • Add new row of data when tabbing out of last row/column when option is on.
  • Ability to run js code when adding or deleting row of record.

fixes #813

ibelar and others added 3 commits October 7, 2019 09:40
- add jsCallback when adding or deleting a row.
- Ability to run js when adding or deleting row.
- Add new line of record when tabbing out of the last row/column
@ibelar ibelar changed the title Feature/MultiLine Improvement Fix/MultiLine Improvement Oct 7, 2019
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #816 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #816      +/-   ##
=============================================
+ Coverage      76.28%   76.29%   +0.01%     
  Complexity      2294     2294              
=============================================
  Files            119      119              
  Lines           5414     5417       +3     
=============================================
+ Hits            4130     4133       +3     
  Misses          1284     1284
Impacted Files Coverage Δ Complexity Δ
src/FormField/MultiLine.php 37.54% <100%> (+0.61%) 140 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a8581...9b23f50. Read the comment docs.

@romaninsh romaninsh merged commit 24c81a7 into develop Oct 8, 2019
@romaninsh romaninsh deleted the feature/multiline-improvement branch October 8, 2019 10:00
@ibelar ibelar mentioned this pull request Oct 26, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline creates a new row when in any input field enter key is pressed
2 participants