Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Locale class #819

Merged
merged 10 commits into from
Oct 25, 2019
Merged

Add Locale class #819

merged 10 commits into from
Oct 25, 2019

Conversation

abbadon1334
Copy link
Collaborator

Add Locale class to find default localization definitions

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #819 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #819      +/-   ##
=============================================
+ Coverage       76.4%   76.42%   +0.01%     
- Complexity      2297     2299       +2     
=============================================
  Files            119      120       +1     
  Lines           5434     5438       +4     
=============================================
+ Hits            4152     4156       +4     
  Misses          1282     1282
Impacted Files Coverage Δ Complexity Δ
src/Locale.php 100% <100%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abeda03...93d1016. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Merge or add more..

@abbadon1334 abbadon1334 merged commit 7d99e80 into develop Oct 25, 2019
@abbadon1334 abbadon1334 deleted the abbadon1334-locale branch October 25, 2019 08:40
@abbadon1334
Copy link
Collaborator Author

let's merge this and add another for start translating prefixed with WIP, few more busy days and i will start it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants