Refactor of User Action Executor #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/js-argument-form
… feature/user-action
Codecov Report
@@ Coverage Diff @@
## develop #820 +/- ##
=============================================
- Coverage 76.4% 73.17% -3.24%
- Complexity 2297 2544 +247
=============================================
Files 119 122 +3
Lines 5434 5916 +482
=============================================
+ Hits 4152 4329 +177
- Misses 1282 1587 +305
Continue to review full report at Codecov.
|
move loader set function to jsRender so we could apply afterSuccess or jsSuccess after setAction is done. Add jsSuccess and stateContext
Closed
add demos/test to gitignore
Codecov Report
@@ Coverage Diff @@
## develop #820 +/- ##
==========================================
Coverage ? 71.85%
Complexity ? 2446
==========================================
Files ? 122
Lines ? 5931
Branches ? 0
==========================================
Hits ? 4262
Misses ? 1669
Partials ? 0
Continue to review full report at Codecov.
|
This was referenced Oct 28, 2019
Action that required an event must be expicitly set using jsEvent
ibelar
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Action Executor allows you to bind UI elements with User Actions defined in the model.
Conveniently executor will ask user for missing arguments, provide user with a preview, if action supports a preview and will also show the result of action execution.
More information is comming.