Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Refactor View::on() method #831

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Oct 30, 2019

Allow for on method to receive a Model UserAction as second arguments.

Usage

$ac = $country->getAction('add');
$btn = $app->add(['Button', $ac->getDescription()]);
$btn->on('click', $ac);

see demos/jsactions2.php for more way on how to use it.

ibelar and others added 2 commits October 30, 2019 11:46
Allow for on method to receive a Model UserAction as second arguments.
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #831 into develop will increase coverage by 1.16%.
The diff coverage is 91.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #831      +/-   ##
===========================================
+ Coverage      72.84%    74%   +1.16%     
- Complexity      2432   2449      +17     
===========================================
  Files            123    123              
  Lines           5766   5801      +35     
===========================================
+ Hits            4200   4293      +93     
+ Misses          1566   1508      -58
Impacted Files Coverage Δ Complexity Δ
src/ActionExecutor/UserAction.php 27.27% <ø> (+23.32%) 96 <0> (ø) ⬇️
src/View.php 87.15% <87.5%> (-0.02%) 155 <0> (+9)
src/ActionExecutor/jsEvent.php 90.69% <95.23%> (+6.82%) 23 <11> (+8) ⬆️
src/Loader.php 96% <0%> (+4%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae36b63...f9be6a3. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome !! 👌

@romaninsh romaninsh merged commit 7027094 into develop Oct 30, 2019
@romaninsh romaninsh deleted the feature/refactor-on-method branch October 30, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants