Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Table Menu Action #833

Merged
merged 16 commits into from
Nov 7, 2019
Merged

Feature/Table Menu Action #833

merged 16 commits into from
Nov 7, 2019

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Nov 4, 2019

Implementation of Dropdown menu item in table.

$g = $app->add(['Grid']);
$g->setModel(new $Country($db));
$g->addActionMenuItem('edit'); // will add model edit action as a menu item
$g->addActionMenuItem('test', new jsExpression('console.log("testing")));

see demos/jsactionsgrid.php for usage with model action.

Screen Shot 2019-11-04 at 12 14 15 PM

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #833 into develop will increase coverage by <.01%.
The diff coverage is 77.55%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #833      +/-   ##
=============================================
+ Coverage      73.34%   73.35%   +<.01%     
- Complexity      2477     2514      +37     
=============================================
  Files            124      125       +1     
  Lines           5831     5919      +88     
=============================================
+ Hits            4277     4342      +65     
- Misses          1554     1577      +23
Impacted Files Coverage Δ Complexity Δ
src/View.php 87.29% <100%> (+0.25%) 159 <0> (+3) ⬆️
src/Grid.php 73.71% <57.14%> (-2.7%) 79 <11> (+9)
src/TableColumn/Actions.php 80.39% <58.82%> (-14.48%) 22 <12> (+6)
src/TableColumn/ActionMenu.php 88.67% <88.67%> (ø) 19 <19> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f1909...5ced3dc. Read the comment docs.

ibelar and others added 5 commits November 4, 2019 14:28
Add ability to setup apiConfig for jsCallback.
Fix dropdown when place inside a column table.
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romaninsh romaninsh merged commit 5661df4 into develop Nov 7, 2019
@romaninsh romaninsh deleted the feature/table-menu-action branch November 7, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants