Feature/refactor crud2 #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments clean up.
Add ability to setup apiConfig for jsCallback.
Codecov Report
@@ Coverage Diff @@
## develop #835 +/- ##
=============================================
- Coverage 73.35% 68.65% -4.71%
- Complexity 2514 2578 +64
=============================================
Files 125 126 +1
Lines 5919 6049 +130
=============================================
- Hits 4342 4153 -189
- Misses 1577 1896 +319
Continue to review full report at Codecov.
|
romaninsh
commented
Nov 13, 2019
| $single_record_action->ui['executor'] = $executor; | ||
| $executor->addHook('afterExecute', function ($x, $m, $id) { | ||
| return $m->loaded() ? $this->jsSave($this->notifyDefault) : $this->jsDelete(); | ||
| }); |
…ure/refactor-crud2
- fixed table border - fixed js when table dropdown menu appear near end of window - Delete action should be fixed in atk4\data remove floating css class to table dropdown menu View::On method now check for action confirmation property and apply it by default
|
While refactoring this I think it would be worth it to also fix #837 |
Added to a new page tutorial_actions for test to work again
|
@ibelar still breaks test.. is it due to dependency on atk data branch? |
|
@romaninsh - Look like it. Seem the error come from calling getConfirmation() on the atk4/Data/UserAction/Generic |
|
@ibelar let me merge and then test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor CRUD to rely on new actions, clean up older implementation(s)