Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the columnProcess Lineage and a bug #2972

Merged
merged 3 commits into from
May 3, 2024
Merged

Fixed the columnProcess Lineage and a bug #2972

merged 3 commits into from
May 3, 2024

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented May 1, 2024 •
edited
Loading

Change description

Fixed the columnProcess Lineage and a bug which was causing 2 simultaneous sync and async tasks being executed for the same tag propagation.

Type of change

  • Bug fix (fixes an issue)

Related issues

Fix Tag Propagation through lineage and hierarchy - ColumnProcess

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

hr2904 added 3 commits May 1, 2024 15:05
@hr2904
Removed Column Lineage
a34d552
@hr2904
Fixed the updatedTagPropagation logic that was running the compute pr…
0ec7b74 
…opagatedEntityVertices logic even when it should not have
@hr2904
edge case missed
160e7bd 
Incase all options are true
error should be thrown
checkaayush
checkaayush approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@checkaayush checkaayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please get an approval from Suman/Anshul before merging.

sumandas0
sumandas0 approved these changes May 2, 2024
View reviewed changes
Copy link

@sumandas0 sumandas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@hr2904 hr2904 merged commit 6f22505 into master May 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumandas0 sumandas0 sumandas0 approved these changes

@checkaayush checkaayush checkaayush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hr2904 @checkaayush @sumandas0