Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PES-2401: changed maximum length limit for attributes ( master ) #3176

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

Vanshaj-Atlan
Copy link

@Vanshaj-Atlan Vanshaj-Atlan commented May 31, 2024

Change description

Updated map to increase length limit for 2 attributes, wrt to ticket 1 and ticket 2

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Tested on beta with postman on PES tenant

  • variablesSchemaBase64
image image
  • visualBuilderSchemaBase64
image image

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@arniesaha
Copy link
Collaborator

arniesaha commented Jun 4, 2024

Tested on beta with postman on PES tenant

@Vanshaj-Atlan can you add the tenant details where this is available. Also a sample curl request with this change?

@Vanshaj-Atlan
Copy link
Author

@arniesaha This is available across all beta tenants #3170

I will share a sample curl for reference run on PES tenant

curl.txt

The variablesSchemaBase64 is longer than 100k+ characters here
image

@sumandas0 sumandas0 merged commit 2e9583d into master Jun 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants