Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG + 1] Create a new figure and test each plot type #127 #179

Merged
merged 9 commits into from
Nov 2, 2018
Merged

[MRG + 1] Create a new figure and test each plot type #127 #179

merged 9 commits into from
Nov 2, 2018

Commits on Oct 27, 2018

  1. [MRG] Create a new figure and test each plot type atlanhq#127 

     - move `plot()` to `plotting.py` as `plot_pdf()`
 - modify plotting functions to return matplotlib figures
 - add `test_plotting.py` and baseline images
 - import `plot_pdf()` in `__init__`
 - update `cli.py` to use `plot_pdf()`
 - update advanced usage docs to reflect changes
    @suyashb95
    suyashb95 committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    dbf68a4 View commit details
    Browse the repository at this point in the history

  2. Change matplotlib backend for image comparison tests

    @suyashb95
    suyashb95 committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    336fee8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2018

  1. Update plotting and tests 

     - use matplotlib rectangle instead of `cv2.rectangle` in
`plot_contour()`
 - set matplotlib backend in `tests/__init__`
 - update contour plot baseline image
 - update `test_plotting` with more checks
    @suyashb95
    suyashb95 committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    5924d95 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. Update plot tests and config 

     - remove unnecessary asserts
 - update setup.cfg and makefile with `--mpl`
    @suyashb95
    suyashb95 committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    9dad125 View commit details
    Browse the repository at this point in the history

  2. Add to

    @suyashb95
    suyashb95 committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    0af6517 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Add tolerance

    @vinayak-mehta
    vinayak-mehta committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    837a657 View commit details
    Browse the repository at this point in the history

  2. remove text from baseline plots 

    update plot tests with `remove_text`
    @suyashb95
    suyashb95 committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    d0edd43 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2018

  1. Change method name, update docs and add pep8

    @vinayak-mehta
    vinayak-mehta committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    c83ebc2 View commit details
    Browse the repository at this point in the history

  2. Update docs

    @vinayak-mehta
    vinayak-mehta committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    655c4f9 View commit details
    Browse the repository at this point in the history