Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pika auth for rpc_queue_consumer #254

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Fix pika auth for rpc_queue_consumer #254

merged 2 commits into from
Apr 12, 2024

Conversation

italovalcy
Copy link
Contributor

Fixes #253

We missed that change above, which ultimately results on the following error when running the full integration.

@coveralls
Copy link

coveralls commented Apr 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8654513651

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.923%
Totals Coverage Status
Change from base Build 8468607472: 0.0%
Covered Lines: 705
Relevant Lines: 1415
💛 - Coveralls

@italovalcy italovalcy mentioned this pull request Apr 11, 2024
Merged
@italovalcy italovalcy merged commit 233afcb into main Apr 12, 2024
11 checks passed
@italovalcy italovalcy deleted the fix/pika_auth branch April 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congwang09 congwang09 congwang09 approved these changes

@sajith sajith Awaiting requested review from sajith

@YufengXin YufengXin Awaiting requested review from YufengXin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing rabbitmq auth in rpc_queue_consumer
3 participants
@italovalcy @coveralls @congwang09