Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete connection #288

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Delete connection #288

merged 7 commits into from
Jun 13, 2024

Conversation

congwang09
Copy link
Contributor

@congwang09 congwang09 commented Jun 12, 2024

Resolves: #261

Enable sdx-controller to delete connection.

@YufengXin
Copy link
Collaborator

the TOX (readme) that Sajith did is probably the easiest way for testing/debugging.

@congwang09
Copy link
Contributor Author

the TOX (readme) that Sajith did is probably the easiest way for testing/debugging.

There are other code checks besides tests. We should probablly enable build per commit, so we can put up PR when the code is really ready for review. I'll look into this.

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9487507499

Details

  • 19 of 23 (82.61%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 52.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/controllers/connection_controller.py 4 5 80.0%
sdx_controller/handlers/connection_handler.py 14 17 82.35%
Files with Coverage Reduction New Missed Lines %
sdx_controller/utils/db_utils.py 1 93.94%
Totals Coverage Status
Change from base Build 9482700199: 0.09%
Covered Lines: 748
Relevant Lines: 1456

💛 - Coveralls

@YufengXin
Copy link
Collaborator

@congwang09 looks like you need to rebase with 'main'

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9488709149

Details

  • 19 of 23 (82.61%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 52.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/controllers/connection_controller.py 4 5 80.0%
sdx_controller/handlers/connection_handler.py 14 17 82.35%
Files with Coverage Reduction New Missed Lines %
sdx_controller/utils/db_utils.py 1 93.94%
Totals Coverage Status
Change from base Build 9487554018: 0.09%
Covered Lines: 748
Relevant Lines: 1456

💛 - Coveralls

@congwang09 congwang09 merged commit bbbb35b into main Jun 13, 2024
11 checks passed
@congwang09 congwang09 deleted the remove-connection branch June 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify LC on connection deletions
4 participants