Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tox-docker expose directive #148

Merged
merged 9 commits into from
Jun 14, 2024
Merged

Use tox-docker expose directive #148

merged 9 commits into from
Jun 14, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Jun 14, 2024

Resolves #147 by splitting MONGODB_CONNSTRING to MONGO_HOST, MONGO_PORT, MONGO_USER, and MONGO_PASS.

Similar to atlanticwave-sdx/sdx-controller#292.

@sajith sajith self-assigned this Jun 14, 2024
@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9519342188

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 77.386%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_lc/utils/db_utils.py 9 11 81.82%
Totals Coverage Status
Change from base Build 9486649041: -0.08%
Covered Lines: 978
Relevant Lines: 1208
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9519390089

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 77.386%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_lc/utils/db_utils.py 9 11 81.82%
Totals Coverage Status
Change from base Build 9486649041: -0.08%
Covered Lines: 978
Relevant Lines: 1208
💛 - Coveralls

YufengXin
YufengXin approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@sajith sajith merged commit 7d6e15b into main Jun 14, 2024
9 checks passed
@sajith sajith deleted the 147.use-tox-expose-directive branch June 14, 2024 17:10
@italovalcy italovalcy mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

@congwang09 congwang09 Awaiting requested review from congwang09

Assignees

@sajith sajith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tox-docker 5.0.0 has deprecated ports
3 participants
@sajith @coveralls @YufengXin