Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Git submodule #3405

Closed
oblivikun opened this issue May 25, 2024 · 2 comments · Fixed by #3406
Closed

Invalid Git submodule #3405

oblivikun opened this issue May 25, 2024 · 2 comments · Fixed by #3406

Comments

@oblivikun
Copy link

oblivikun commented May 25, 2024

Describe the bug
There is a submodule specified that the url does not exist `
[submodule "_build/devel"]
path = _build/devel
url =https://gitlab.common-lisp.net/misc-extensions/devel.git

`
Precise recipe to reproduce the issue
git clone --recurse-submodules https://github.com/atlas-engineer/nyxt
For website-specific issues:
Can you reproduce this issue with Epiphany / GNOME Web (https://wiki.gnome.org/Apps/Web)?

Information

  • OS name+version:
  • Graphics card and driver:
  • Desktop environment / Window manager name+version:
  • Installation method (Flatpak, Guix, package manager, build from source):
  • Output of nyxt --system-information:

Output when started from a shell

@aadcg
Copy link
Member

aadcg commented May 25, 2024

@oblivikun thanks for reporting.

The library is now hosted elsewhere. Fixed via 832174d.

@aadcg aadcg closed this as completed May 25, 2024
@aadcg
Copy link
Member

aadcg commented May 25, 2024

This is not yet fixed because some dependencies (such as nfiles) also depend on the library and register it as a git submodule. AFAIK, there's no way to run git clone --recurse-submodules ... exclusively on direct submodules.

While we could fix the URL everywhere, there is no good reason for these CL libraries (maintained by @atlas-engineer/atlas) to register their dependencies as git submodules. It enables running CI routines in their own repositories, which isn't wise from a maintenance perspective since that env must be kept with sync with that of Nyxt. It would wiser to run the test suite of those libraries within Nyxt's CI.

I'll take this opportunity to fix the long standing issue mentioned above.

@aadcg aadcg reopened this May 25, 2024
@aadcg aadcg mentioned this issue May 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants