This repository has been archived by the owner on Nov 17, 2017. It is now read-only.
fix(atlas-java): Java inspection forces FieldType to COMPLEX for othe… #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than primitives, which breaks DATE/TIME related types Fixes: #234 Also addresses: Java inspection should not inspect JDK classes Fixes: #252 Java field inspection ignores package private fields Fixes: #253 Add an inspection unit test with package private Class to confirm class accessibility issues Fixes: #85
1 similar comment
jpav
approved these changes
Oct 31, 2017
| Optional<AtlasConverter> primitiveConverter = Optional.empty(); | ||
| Optional<AtlasConverter> customConverter = Optional.empty(); | ||
| Optional<AtlasConverter<?>> primitiveConverter = Optional.empty(); | ||
| Optional<AtlasConverter<?>> customConverter = Optional.empty(); |
There was a problem hiding this comment.
These were there before, but the declarations and definitions above are unnecessary since both variables are redefined below in lines 81 and 85. The declarations should probably be moved there.
|
Well, crap, I didn't realize pure-bot would auto-merge after a review... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r than primitives, which breaks DATE/TIME related types
Fixes: #234
Also addresses:
Java inspection should not inspect JDK classes
Fixes: #252
Java field inspection ignores package private fields
Fixes: #253
Add an inspection unit test with package private Class to confirm class accessibility issues
Fixes: #85