Add a failing test and fix the field assigned on set #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harikt
commented
Oct 15, 2016
| 'zim' => 'dim' | ||
| ]); | ||
|
|
||
| $actual = $this->record->getArrayCopy(); |
There was a problem hiding this comment.
The getArrayCopy is failing.
Didn't understand why so. May be late night :) .
There was 1 error:
1) Atlas\Orm\Mapper\RecordTest::testSet
Error: Call to a member function getArrayCopy() on string
/var/www/projects/github.com/harikt/Atlas.Orm/src/Mapper/Related.php:147
/var/www/projects/github.com/harikt/Atlas.Orm/src/Mapper/Record.php:211
/var/www/projects/github.com/harikt/Atlas.Orm/tests/Mapper/RecordTest.php:129
|
Well that's unexpected. I'll take a look. |
|
Aha! It's because Related should only allow you to set null, false, empty array, Record, or RecordSet. Alternatively, getArrayCopy() should check if the thing being copied is a Record or RecordSet before descending into it. |
|
I was just writing. |
|
Need a PR or you patched ? |
|
In case , here is a patch #37 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.