Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default datatype for LoggedStatement->bindValue according to parent class #3

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Add default datatype for LoggedStatement->bindValue according to parent class #3

merged 1 commit into from
Mar 1, 2019

Conversation

MrPetovan
Copy link
Contributor

@MrPetovan MrPetovan commented Nov 2, 2018 •
edited
Loading

This PR adds the default \PDO::PARAM_STR data type value to LoggerStatement->bindValue.

Without this default value, activating the Query Logger make any of the subsequent \Atlas\Pdo\Connection query methods fails when data types aren't provided.

@froschdesign froschdesign mentioned this pull request Mar 1, 2019
Closed
@pmjones pmjones merged commit 3f781f3 into atlasphp:1.x Mar 1, 2019
@MrPetovan MrPetovan deleted the patch-1 branch March 1, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrPetovan @pmjones