Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC-1438 : Update the JiraConfiguration view to show list of GH cloud and GHE organizations separately #1319

Merged
merged 69 commits into from
Jul 22, 2022

Conversation

krazziekay
Copy link
Collaborator

@krazziekay krazziekay commented Jul 1, 2022

Changes

  • Frontend
    • Updated the list of connections as the list of GH Cloud apps.
    • Created a new section for the list of GH servers.
  • Backend
    • Added a new method to fetch the list of GH server apps for a given installationId
    • Used this method to fetch the list of GH server apps.
    • Modified the list of GH servers to get the desired output

Video

https://www.loom.com/share/b33c06f6fa4149d4be38deb488be7702

@krazziekay krazziekay self-assigned this Jul 1, 2022
@krazziekay krazziekay marked this pull request as ready for review July 1, 2022 03:32
@krazziekay krazziekay requested a review from a team as a code owner July 1, 2022 03:32
src/routes/jira/configuration/jira-configuration-get.ts Outdated Show resolved Hide resolved
views/jira-configuration.hbs Outdated Show resolved Hide resolved
src/util/handlebars/handlebar-helpers.ts Outdated Show resolved Hide resolved
views/jira-configuration.hbs Outdated Show resolved Hide resolved
views/jira-configuration.hbs Outdated Show resolved Hide resolved
views/jira-configuration.hbs Outdated Show resolved Hide resolved
Copy link
Contributor

@mboudreau mboudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I few small things to change but well done for the most part. This has been tested thoroughly on staging I imagine?

@rachellerathbone
Copy link
Contributor

I few small things to change but well done for the most part. This has been tested thoroughly on staging I imagine?
@mboudreau until we've completed the auto app flow (should hopefully be in the next couple of days) there's no way for us to test as there GHSA table is currently empty. I think we should aim to get this PR ready to be merged but maybe hold off on doing that until a flow is complete and it can be tested in stg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants