Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CHANGELOG.md and switch to github releases #265

Open
tiedotguy opened this issue Sep 21, 2019 · 6 comments
Open

Drop CHANGELOG.md and switch to github releases #265

tiedotguy opened this issue Sep 21, 2019 · 6 comments
Labels

Comments

@tiedotguy
Copy link
Collaborator

Currently changes are tracked in [CHANGELOG.md], including the version, which is a bit of a pain to manage if there's more than 1 thing going on at a time due to merge conflicts on a non-critical file.

Historically I've cleaned this up by just pushing to master, however that's not an option anymore. As such, I propose dropping it (marking it as deprecated but leaving it for historical value) entirely and switching to github releases. This would be done after #264

Personally I'm not a big fan of having the history tied to the github ecosystem rather than the repo, but I value the productivity more.

@tiedotguy
Copy link
Collaborator Author

opinions, @ash2k, @aelse ?

@ash2k
Copy link
Contributor

ash2k commented Sep 21, 2019

👍

@aelse
Copy link
Member

aelse commented Sep 24, 2019

Doesn't a merge from master into a branch before raising a PR solve this? We're not so fast moving that changelog gets frequent updates.

@tiedotguy
Copy link
Collaborator Author

It does, but it effectively serializes the PR process, and #260 is up to 3 merges now.

@aelse
Copy link
Member

aelse commented Sep 25, 2019

If we switch to github releases it makes this project more of a snowflake concern for us to manage and I want to avoid that. It doesn't seem like it's a huge burden to resolve conflicts in a markdown file, even if it happens 2 or 3 times in the course of a long running PR.

If we can do better on reducing the time it takes to get changes merged in this problem probably goes away for the most part. Not all of us are paid to work on this project (any more, @tiedotguy 😄) and any time given is a gift, but I'll put more focus on giving timely feedback in future

@MovieStoreGuy
Copy link
Contributor

I think it is fair enough to say that we carry on with using the change log and using tagged commits @tiedotguy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants