Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lerna) Add Lerna 3.x.x support #97

Open
wants to merge 3 commits into
base: caribou
Choose a base branch
from

Conversation

CowDotDev
Copy link

Updated the packages to support the new file structure of Lerna v3.x.x and fixed tests that were throwing errors. Versions have not been incremented from their original values for this PR.

Zach Case added 3 commits September 24, 2019 07:38
affects: lerna-semantic-release-analyze-commits, lerna-semantic-release-get-last-release,
lerna-semantic-release-io, lerna-semantic-release-perform, lerna-semantic-release-post,
lerna-semantic-release-pre, lerna-semantic-release-utils, lerna-semantic-release
@CowDotDev CowDotDev mentioned this pull request Sep 24, 2019
@CowDotDev
Copy link
Author

This is my fix towards issue: #93

CowDotDev referenced this pull request in silouanwright/lerna-semantic-release Sep 24, 2019
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
@CowDotDev
Copy link
Author

Not quite sure how to fix those "empty" change commits, I'll try to fix that when I get a chance to clean up the PR.

@lukebatchelor
Copy link
Member

Thanks heaps @zachcase , I definitely don't have any time to be spending on this, but if you're able to get this working, give me a shout and I can look at merging / releasing.

Thanks @reywright for the massive start on it too.

@CowDotDev
Copy link
Author

@lukebatchelor Apologies on the almost month delay, I have been using this regularly since and haven't had to make any changes. Seems to be working great! I'll try to set some time to make sure what I've been using for my projects hasn't diverged from this PR (I don't think I've had to make any changes since creating the PR). I'll give you a ping when I have looked it over and cleaned it up.

@rewathkafley
Copy link

When is this getting resolved? I really need the new version support.

@ocombe
Copy link

ocombe commented Dec 5, 2019

@zachcase with your PR I still get "lerna-semantic-release is not recognized as an internal or external command" (the binary is not created in the bin folder), does it work for you?

@joerstom
Copy link

Will this ever get merged? I'm having trouble working with lerna^2.0.0 and semantic-release. Thank you!

@SheepFromHeaven
Copy link

Any way we can help to get this PR merged? @zachcase

@hseghetti
Copy link

Is there any plan to fix and merge this PR ?
Thank you!

@lukebatchelor
Copy link
Member

If someone is able to finish and test it, it can be merged for sure.

@thebergamo
Copy link

@CowDotDev if you provide a test case for the issue that you've I would like to try to fix it, so we could have this merged.

@CowDotDev
Copy link
Author

My apologies on this sitting, I made this PR at a point in time that I no longer can recall any of this. I can not say I have time to give to this at the moment to refamiliarize myself to provide adequate test cases, especially given that comments seem to indicate there is still an error being thrown. If I have time this holiday weekend, I can try to see where my repo is at.

However, if someone who is fresher with this wants to take lead, feel free to fork my repo and we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants