Add custom mutator docs and types fix #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #52 |
|
Hi Alberto. My previous account was deleted, but I have tested these new changes. It looks great, except there should be a note in the docs about if immerjs is used with overriding the SetState interface, the TState used must not be a Readonly type since the TState is a draft state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current TS type definition does not allow customisation of
setStateto accomodate a custom mutator. By using an interface we can overloadsetStatedefinition tu allow custom arguments (like a function).I've also relaxed the types of the default mutator so TS does not complain on the actual implementation of it and
setStatecan be called with anything.