-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom theme #134
Feature/custom theme #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В направлении одного из вариантов идешь. Главное - тестируй параллельно, а еще лучше пиши в пакете тесты - так точно убедимся в работоспособности
@Nelfimov, пока что без тестов. Посмотри логику. |
packages/payment-widget/src/interfaces/custom-elements.interfaces.ts
Outdated
Show resolved
Hide resolved
packages/payment-widget/src/interfaces/custom-elements.interfaces.ts
Outdated
Show resolved
Hide resolved
Не прикрепил задачу и не поставил себя в ответственные. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
понятие кастомных элементов не может работать нормально, при таком раскладе мы теряем контроль, так как кастомные элементы неизвестны и надо лезть вовнутрь
@Nelfimov, сейчас пробую такой подход:
input.component.tsx:
form-content.component.tsx:
input.component.tsx:
Но сталкиваюсь с такой же проблемой как если предавать массив "стилей" |
Тогда попробуй подход из соседнего пакета |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И покажи пример как ты будешь использовать враппер
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
почистить any
Создал ПР torin-asakura/drum-in#124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
почти
packages/payment-widget/src/ui/wrapper/button-wrapper.component.tsx
Outdated
Show resolved
Hide resolved
packages/payment-widget/src/ui/wrapper/button-wrapper.component.tsx
Outdated
Show resolved
Hide resolved
packages/payment-widget/src/ui/wrapper/button-wrapper.component.tsx
Outdated
Show resolved
Hide resolved
packages/payment-widget/src/ui/wrapper/input-wrapper.component.tsx
Outdated
Show resolved
Hide resolved
…s, fix interfaces
No description provided.