-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CPP API documentation #236
Conversation
No problem. We should make more use of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation looks good to me. Just marked some typos. Thanks for providing documentation for the interface.
We currently still support building without OpenMP. This adds an ifdef to fix a compile error for that scenario.
From my side this PR is ready for master after you merge riclarsson#8 to fix the non-OpenMP build issue. Anything else pending from your side? |
Fix non-OpenMP build
There is plenty of small things that could be done to improve this but there are no show-stoppers. Some are modular and some are not. A short list:
If any of these things are "easy" and "directly useful now", I would have added them. Presently, there is no modules so they are not pressing, and the variadic stuff is just too complicated. Edit: So so long as the failing test isn't really failing but yet another github artifact, I am fine with merging now. |
You were a bit too quick with the merge Oliver, I thought I would have time to add some documentation before the merge.
This adds documentation, renames some types, and allow setting some more global states.
I would like someone to comment on if the documentation makes sense.
I am unsure about the rename and would be willing to revert it. Before ARTS::Var::WorkspaceIndex was a thing. To be more consistent, it is now called ARTS::Var::Index. The latter does not interfere with the global Index, and everything inside the Var namespace knows it has to use a Var::Index. Everywhere else, it is anyways necessary to use Var::Index, so this does not interfere either with Var::Index. It thus made more sense to me to have as common a tongue as we can have here. The hope is anyways that when modules are a thing that there will be no access to the global Index, so then the namespaces having their own similarly named types makes a lot more sense than to have the longer WorkspaceIndex abomination of a name. Of course, this all applies to all Groups.