Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover mentions of scat_species_XXX_field #242

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

olemke
Copy link
Member

@olemke olemke commented Oct 9, 2020

Question @m-brath, @erikssonpatrick : I've removed some leftover mentions of scat_species_XXX_field in methods.cc, but I'm struggling with the documentation for cloudboxSetAutomatically. It also refers to scat_species_XXX_field in several sentences. I'm especially unsure how to correct the second paragraph that ends with:

For the latter, the WSM needs to be called once per each scat_species_XXX_field, with previously determined cloudbox_limits provided through cloudbox_limits_old.

Does "the latter" here refer explicitly to scat_species_XXX_field and if so, does that mean that cloudbox_limits_old has no use anymore?

@erikssonpatrick
Copy link
Contributor

Seems that the WSM is still using the old PSD system, so I have to refer to @m-brath.

However, I would say that the text here is not critical for v2.4, but the WSM and its text should be updated to v3 as part inside issue #206.

In line with what I write for CHANGES, the question is if we bother to document all around the old PSD system, as we plan to remove it.

Remove scat_species_XXX_field leftovers.
@olemke
Copy link
Member Author

olemke commented Oct 13, 2020

Updated docs for cloudboxSetAutomatically after discussion with @m-brath

@olemke olemke marked this pull request as ready for review October 13, 2020 06:58
@olemke olemke merged commit 1f9b1b9 into atmtools:master Oct 13, 2020
@olemke olemke deleted the cleanup-scat-species-field branch October 13, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants