Minor things #263
Merged
Minor things #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix missing "Group::"
The latter is more accurate for low values, i.e., when I gets large
Actually, quite a few of the variables in the init-function were unused in practice, so they should be removed
only place using it. I want to eliminate iy_transmittance_mult from rte.h and rte.cc as well but cannot at the moment since they are used in methods of m_fos.cc and m_surface.cc (we really should be passing TransmissionMatrix around the boundaries because that would be a lot faster and allow to remove some of these 'help me do a simple multiplication' functions). I sadly had to put the two removed functions also in test_omp.cc since we rely on old RT code to test OpenMP functionality. The latter I do not consider important, even though it means code duplication, because it is not duplicated inside ARTS but just for an external test case (though it would be nice to be able to remove some of the lin-alg that I added for the old methods when we realized that the original lin-alg implementation was unecessarily slow.)
|
I'll remove the test_omp since it's outdated and not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are many minor changes to some code. The main thing is removing a very large function dealing with the setup of the Jacobian calculations because it wasn't really being used. The rest are just constifying some variables and using more accurate maths in some of the derivatives.