Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makarov2020 o2 #272

Merged
merged 10 commits into from
Dec 8, 2020
Merged

Makarov2020 o2 #272

merged 10 commits into from
Dec 8, 2020

Conversation

riclarsson
Copy link
Contributor

This is a bit of a mess of a commit. Three things: 1) I am adding a few more ways to plot, mostly multiple lines, and showing an example in test_gui.cc. 2) I am changing how to set line shape parameters from within a controlfile. 3) I am attempting again to implement Makarov etal 2020 O2 line mixing ECS model. I think I am very close this time, and that it is probably possible to use the model without much hassle. I still need to confirm this but it is a good step towards finishing #136 .

Anyways, as a test for how to use the debug GUI, I added a simple test_gui build that shows the below plot:
Screenshot from 2020-12-03 16-37-44

The shown plot are the differences between my implementation of ECS and MPM and pure line-by-line based on Makarov etal 2020.

@riclarsson
Copy link
Contributor Author

I think this can be merged. There are probably still some bugs but nothing that should be a show-stopper before it is tried out.

The code attempts to solve the GUI debug documentation thing and it mostly solves the ECS implementation errors.

For the latter, there are still differences between online ECS and my own. I don't know where they are from but suspect that I am either coupling too few lines or that the online version has a bad Wigner-implementation (I have seen the latter in some old Fortran code that in my previous tests turned out to be very inaccurate, so this is why I am suspecting it.) I hope it is the former because otherwise we have to use slower and less accurate Wigner symbols in ARTS to use online results.

@olemke
Copy link
Member

olemke commented Dec 8, 2020

I will remove the 9d87062 commit (from #267) once more from this PR before merging to keep things clean(I did this this morning, but you just force-pushed it back in ;-) ).

@riclarsson
Copy link
Contributor Author

Thanks, Oliver! I still don't understand fully how this platform works. Force pushing is the only thing that seems to work or there is just a big warning message from git.

@olemke olemke merged commit 5587c89 into atmtools:master Dec 8, 2020
@riclarsson riclarsson mentioned this pull request Dec 17, 2020
@riclarsson riclarsson deleted the makarov2020_O2 branch January 19, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants