-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makarov2020 o2 #272
Makarov2020 o2 #272
Conversation
9363895
to
95f2f2e
Compare
3d3ba01
to
bccb2d5
Compare
bccb2d5
to
c7a75f9
Compare
I think this can be merged. There are probably still some bugs but nothing that should be a show-stopper before it is tried out. The code attempts to solve the GUI debug documentation thing and it mostly solves the ECS implementation errors. For the latter, there are still differences between online ECS and my own. I don't know where they are from but suspect that I am either coupling too few lines or that the online version has a bad Wigner-implementation (I have seen the latter in some old Fortran code that in my previous tests turned out to be very inaccurate, so this is why I am suspecting it.) I hope it is the former because otherwise we have to use slower and less accurate Wigner symbols in ARTS to use online results. |
line shape parameters from within a controlfile
calculations per species more explicit. Also added several functions for trying to get Rosenkranz parameters out of the code. These do not yet work. I need some help to fix the Rosenkranz adaptations...
target so long as that branch is never called in a constexpr setting...
c7a75f9
to
76a8521
Compare
Thanks, Oliver! I still don't understand fully how this platform works. Force pushing is the only thing that seems to work or there is just a big warning message from git. |
This is a bit of a mess of a commit. Three things: 1) I am adding a few more ways to plot, mostly multiple lines, and showing an example in test_gui.cc. 2) I am changing how to set line shape parameters from within a controlfile. 3) I am attempting again to implement Makarov etal 2020 O2 line mixing ECS model. I think I am very close this time, and that it is probably possible to use the model without much hassle. I still need to confirm this but it is a good step towards finishing #136 .
Anyways, as a test for how to use the debug GUI, I added a simple test_gui build that shows the below plot:
The shown plot are the differences between my implementation of ECS and MPM and pure line-by-line based on Makarov etal 2020.