New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for OEM #305

Merged

olemke merged 4 commits into atmtools:master from simonpf:oem_fixes

Feb 11, 2021

Contributor

simonpf commented Feb 11, 2021

This fixes three bugs in the OEM and related functions:

Adding of inverse block to covmat_sx now works as expected even for polynomial coefficients when the block indices are omitted. The default behavior when these are omitted is now also described in the WSM documentation.
The value of oem_diagnostics[1] is now set correctly.
LM method now propagates error from inversion_iterateAgenda if maximum lambda factor is reached.

Simon Pfreundschuh added 4 commits

February 10, 2021 17:50


          Added test to cover bug.

e50efad


          Fixed bug in covmat_s*_addInverseBlock for coefficients of a polynomi…

e052ad0

…al fit.


          Fix calculation of oem_diagnostics[1].

653829b


          Raise error if inversion_iterateAgenda fails for maximum lambda factor.

c65407d

olemke merged commit 5951a72 into atmtools:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet