Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto agenda #427

Merged
merged 10 commits into from
May 17, 2022
Merged

Auto agenda #427

merged 10 commits into from
May 17, 2022

Conversation

riclarsson
Copy link
Contributor

This gives automatic agenda settings for propmat clear sky. It requires lines and species to be set. There are a few weirdities in here but I think they are ok.

I'm not using the cpp API. Should this be removed? I don't think that anyone is using it and the pybind stuff is probably easier to link to anyways

@olemke
Copy link
Member

olemke commented May 17, 2022

If you don't use the cpp api anymore, I think it would be best to use that as an opportunity to slim down our APIs by removing it.

@riclarsson
Copy link
Contributor Author

For the record. Some check-all tests will fail with this adaptation. @olemke and I discussed this and the new workspace variable select_abs_species will be made part of more functions than *AddLines in an upcoming lookup-table adaptation. These tests should by then be restored to working order so we decided to not adapt these failing tests with expectations that the problem will fix itself by then.

@olemke olemke merged commit debd63d into atmtools:master May 17, 2022
@riclarsson riclarsson deleted the auto_agenda branch May 17, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants