Faster binio reading #440
Merged
Faster binio reading #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove non-IEEE support. Modernize code. Add new function binistream::readDoubleArray to improve read performance signficantly by bypassing the slow istream::read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new function binistream::readDoubleArray to improve read
performance of binary xml files significantly (up to 20x depending
on disk speed, OS and compiler) by reading directly into the memory
of the matpack variable, bypassing the slow istream::read.
Here are two benchmarks on Linux (GCC x86_64) and on macOS (Clang arm64).
Case 1 is reading a 76MB Vector, case 2 a 760MB GriddedField3:
Both systems show a performance increase of around 15-18x.
Note that the files are cached in memory to benchmark
the actual code performance, not the performance of the disk.
However, all times for the "before" tests are still significantly slower
than the available bandwidth of the underlying SSD could offer.